[Bug 1221781] Review Request: zipios - C++ library for reading and writing Zip files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1221781



--- Comment #27 from Richard Shaw <hobbes1069@xxxxxxxxx> ---
(In reply to Raphael Groner from comment #24)
> %files
> %if 0%{?rhel} < 7 || 0%{?fedora} < 21
> %{_datadir}/licenses/COPYING
> %else
> %{_pkgdocdir}/COPYING
> %endif
> 
> The above is wrong. You confused the logic. Please use:
> 
> %files
> %if 0%{?rhel} >= 7 || 0%{?fedora} >= 22
> %license COPYING
> %endif
> %{_pkgdocdir}/COPYING
> 
> It wouldn't harm to always place COPYING into %{_pkgdocdir}, too.

I caught that as well, I don't need the separate COPYING line at all since it
will be globed by the reference to %{_pkgdocdir}.


(In reply to Raphael Groner from comment #25)
> As F20 is EOL you do not need any version check for Fedora. I am confused
> now, too.

I like to have it in there just in case someone has an older release and is
willing to build the package themselves.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]