[Bug 1193986] Review Request: openstack-rally - Benchmark as a service for OpenStack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1193986



--- Comment #18 from Steve Linabery <slinaber@xxxxxxxxxx> ---
(In reply to Haïkel Guémar from comment #17)
> @Jens You're right about it, forgot about this guideline :)
> 
> @Steve: yes, I must have been tired when I typed, Before you import the
> package, I request you to do these changes:
> * dropping the requirements on bash-completion as explained in #15
> * sed -i 's/pyyaml/PyYAML/g' on spec as there's no pyyaml package and rally
> installs/runs fine after this change.
> * move %{_prefix}%{_sysconfdir}/bash_completion.d/rally.bash_completion to
> %{_sysconfdir}/bash_completion.d/rally.bash_completion
> 
> These are the last mile before approval :)

that %{_prefix}%{_sysconfdir}/bash_completion.d/rally.bash_completion is in
there because that's where setup.py drops that file. from build log:

copying etc/rally.bash_completion ->
/builddir/build/BUILDROOT/openstack-rally-0.0.4-1.fc24.x86_64/usr/etc/bash_completion.d

/me shrugs.

I can add a build step to move it to the suggested location. Please advise.

In the interim I made the other two changes here:
https://slinabery.fedorapeople.org/openstack-rally.spec
https://slinabery.fedorapeople.org/openstack-rally-0.0.4-1.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]