https://bugzilla.redhat.com/show_bug.cgi?id=1263739 --- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> --- Looks quite good but I still have some comments :) * Missing build time deps: - perl(DynaLoader), lib/B/Hooks/Parser.pm:7 - petr(strict), Makefile.PL:5 - perl(warnings), Makefile.PL:6 * Add a version constraint to the perl(ExtUtils::Depends) dependency. Version 0.302 is required -- Makefile.PL:11 * You may safely substitute PERL_INSTALL_ROOT with DESTDIR nowadays. * Don't explicitly (run) require perl(parent), it gets autodected. * I think you should own the %{perl_vendorarch}/auto/B and %{perl_vendorarch}/B directories. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review