https://bugzilla.redhat.com/show_bug.cgi?id=1245932 --- Comment #9 from William Moreno <williamjmorenor@xxxxxxxxx> --- Cool. So please: 1- You SHOULD include the appdata.xlm file, if so, you must include: BuildRequires: libappstream-glib %%check appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/appdata/*.appdata.xml 2- Handle the desktop file with Requires(post): desktop-file-utils Requires(postun): desktop-file-utils %post /usr/bin/update-desktop-database &> /dev/null || : %postun /usr/bin/update-desktop-database &> /dev/null || : 3- You a missing this: BuildRequires: systemd-units 4- Please use the proposed tools to handle the icons in the package and do not forget to include: %post /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : %postun if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi %posttrans /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : 5- Upstream include a test in the repo: https://github.com/juhovh/shairplay/tree/master/src/test So you must run this in %%check 6- Here is a html documentation tha you can include in a airtv-docs subpackage: https://github.com/juhovh/shairplay/tree/master/AirTV-Qt/qtsingleapplication/doc/html 7- There will be a rpmlint warning about a missing manpage, if can include a manpage will good, you can create one using the man-editor package available in repos or writting one with a text editor using the groff format. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review