https://bugzilla.redhat.com/show_bug.cgi?id=1263600 --- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> --- I've mentioned some of these things in your other package review already. Well, here we go. * The package doesn't even build in mock. Seriously? * Missing some build deps: - perl, called in the spec - perl(IO::Handle), lib/Log/Log4perl/Appender/Socket/UNIX.pm:10 - perl(Log::Log4perl::Appender), lib/Log/Log4perl/Appender/Socket/UNIX.pm:5 - perl(Socket), lib/Log/Log4perl/Appender/Socket/UNIX.pm:11 - perl(strict), Build.PL:2 - perl(Test::More), t/1_load.t:16 - perl(warnings), Build.PL:2 * Optional but recommended for build consistency: - perl(Test::NoWarnings), t/1_load.t:8 * Missing a runtime dependency on Log::Log4perl::Appender; this won't get autodetected. * Drop %defattr, it's no longer required. * The Group tag is optional and can be dropped. * License texts need to be packaged using the %license macro. * Consider packaging the `examples' directory as documentation. * The README file is useless in this case. Drop it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review