https://bugzilla.redhat.com/show_bug.cgi?id=1262872 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- -Source0: http://search.cpan.org/CPAN/authors/id/T/TI/TIMBRODY/TeX-Encode-1.3.tar.gz +Source0: http://search.cpan.org/CPAN/authors/id/T/TI/TIMBRODY/TeX-Encode-%{version}.tar.gz +Group: Development/Libraries > FIX: Source0 should contains %{version} instead of explicit version 1.3 > Source0: > http://search.cpan.org/CPAN/authors/id/T/TI/TIMBRODY/TeX-Encode-%{version}. > tar.gz Fixed > TODO: Please add Group tag > Group: Development/Libraries Fixed > TODO: Please replace %{__perl} by 'perl' %build -%{__perl} Makefile.PL INSTALLDIRS=vendor +perl Makefile.PL INSTALLDIRS=vendor make %{?_smp_mflags} Fixed. > FIX: Please add following build-requires > - coreutils - perl-TeX-Encode.spec:35 > - findutils - perl-TeX-Encode.spec:35 > - make - perl-TeX-Encode.spec:31 > - perl - perl-TeX-Encode.spec:30 > - perl(Carp) - lib/TeX/Encode.pm:9 > - perl(Encode) - t/01ltgt.t:9 > - perl(strict) - lib/TeX/Encode.pm:4 > - perl(vars) - lib/TeX/Encode/charmap.pm:13 BuildArch: noarch +BuildRequires: coreutils, findutils, make, perl +BuildRequires: perl(Carp), perl(Encode), perl(strict), perl(vars) BuildRequires: perl(ExtUtils::MakeMaker) Fixed. > FIX: Please replace PERL_INSTALL_ROOT by DESTDIR -make pure_install PERL_INSTALL_ROOT=%{buildroot} +make pure_install DESTDIR=%{buildroot} Fixed > > TODO: The following line could be remove, it is done by rpm > find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';' find %{buildroot} -type f -name .packlist -exec rm -f {} ';' -find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';' Fixed The package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review