https://bugzilla.redhat.com/show_bug.cgi?id=1262872 --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Summary is ok License is ok Description is ok URL is ok All tests passed FIX: Source0 should contains %{version} instead of explicit version 1.3 Source0: http://search.cpan.org/CPAN/authors/id/T/TI/TIMBRODY/TeX-Encode-%{version}.tar.gz TODO: Please add Group tag Group: Development/Libraries TODO: Please replace %{__perl} by 'perl' FIX: Please add following build-requires - coreutils - perl-TeX-Encode.spec:35 - findutils - perl-TeX-Encode.spec:35 - make - perl-TeX-Encode.spec:31 - perl - perl-TeX-Encode.spec:30 - perl(Carp) - lib/TeX/Encode.pm:9 - perl(Encode) - t/01ltgt.t:9 - perl(strict) - lib/TeX/Encode.pm:4 - perl(vars) - lib/TeX/Encode/charmap.pm:13 FIX: Please replace PERL_INSTALL_ROOT by DESTDIR TODO: The following line could be remove, it is done by rpm find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';' $ rpm -qp --requires perl-TeX-Encode-1.3-1.fc24.noarch.rpm | sort | uniq -c 1 perl >= 0:5.008 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(Carp) 1 perl(Encode::Encoding) 1 perl(TeX::Encode) 1 perl(TeX::Encode::BibTeX) 1 perl(TeX::Encode::charmap) 1 perl(strict) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-TeX-Encode-1.3-1.fc24.noarch.rpm | sort | uniq -c 1 perl(TeX::Encode) = 1.3 1 perl(TeX::Encode::BibTeX) = 1.2 1 perl(TeX::Encode::charmap) 1 perl-TeX-Encode = 1.3-1.fc24 Binary provides are Ok. $ rpmlint ./perl-TeX-Encode* perl-TeX-Encode.src: W: spelling-error %description -l en_US LaTeX -> Lat Ex, Late X, Latex perl-TeX-Encode.src: W: spelling-error %description -l en_US undef -> unfed, under, funded perl-TeX-Encode.noarch: W: spelling-error %description -l en_US LaTeX -> Lat Ex, Late X, Latex perl-TeX-Encode.noarch: W: spelling-error %description -l en_US undef -> unfed, under, funded 2 packages and 1 specfiles checked; 0 errors, 4 warnings. Rpmlint is ok Please correct all 'FIX' issues and consider fixing 'TODO' item The package is not approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review