https://bugzilla.redhat.com/show_bug.cgi?id=1245791 Chandan Kumar <chkumar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chkumar@xxxxxxxxxx --- Comment #2 from Chandan Kumar <chkumar@xxxxxxxxxx> --- Hello Pradeep, Thanks for submitting for package review. Below is my inline comments. [1.] include license file as Source1: https://raw.githubusercontent.com/influxdb/influxdb-python/master/LICENSE under %build section copy the license file as cp Source1 . and then include it in %files section as %license LICENSE [2.]under %prep section delete *-requirements.txt using rm -f {test-,dev-,}requirements.tx [3.] under %build and %install section, replace %{__python} to %{__python2} [4.] Since the tarfile contains the documentation of influxdb please build the documentation under %build section using sphinx-build -b html docs/source docs/build and create a doc subpackage. [5.] Since this package is python3 supported, Please create python2 and python3 subpackge : https://fedoraproject.org/wiki/Packaging:Python [6.] you can also run tests under %check section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review