[Bug 1250887] Review Request: preprocess - A portable multi-language file Python2 preprocessor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1250887



--- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to Antonio Trande from comment #3)
> Indeed; i have used the file already installed on buildroot.

Okay, that's good, but two of the other issues have not been addressed, namely:

- Package uses either %{buildroot} or $RPM_BUILD_ROOT
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros

- Note the non-executable script complaint by rpmlint.  Either the library
  file should be executable (in which case, the shebang expression should
  be #!/usr/bin/python2 for %{python2_sitelib}/preprocess.py and
  #!/usr/bin/python3 for %{python3_sitelib}/preprocess.py), or the file
  should not be executable, in which case the shebang should be removed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]