https://bugzilla.redhat.com/show_bug.cgi?id=1258874 --- Comment #17 from Jan Včelák <jv+fedora@xxxxxxxxx> --- Thank you for the review. > 1. I'm against that -utils subpackage, better include it in -devel. Only one > program doesn't need to be placed into another subpackage, time to reduce > pointless subpkgs. I think it is useful to have the utility to query the database even if you don't do any development. It was logical for me to put it into a subpackage. On the other hand, the -devel subpackage has almost no dependencies, so I'm also fine with placing the utility into the -devel subpackage. > 2. Group: Development/Libraries > > Drop it, it doesn't matter on RHEL6, and RHEL5.10+(IIRC) OK. I'll do that. > 3. I'd rather put > > %doc NOTICE Changes.md > > to -devel subpkg. OK. Makes sense. > 4. %doc NOTICE > > No, it's %license. OK. Good catch. > 5. Looks like some code are bundled in tests, but using git submodule is ok > so I will ignore this. I think this is OK. The test binaries are not installed. There is a bunch of libtap libraries around and this one is not packaged in Fedora. And it would be pity to remove the tests execution from the build process. I'll post updated specs soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review