[Bug 1246792] Review Request: ndctl - Manage "libnvdimm" subsystem devices (Non-volatile Memory)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1246792



--- Comment #16 from Dan Williams <dan.j.williams@xxxxxxxxx> ---
(In reply to David Woodhouse from comment #15)
> > Rpmlint (installed packages)
> > ----------------------------
> > ndctl-libs.x86_64: W: invalid-license LGPLv2.1
> 
> See https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses
> — I think that should be 'LGPLv2'.

Ok, will fix.

> But also, why does nfit.h have a licence header therein claiming that it's
> under GPL and not LGPL?

There's the library (libndctl) that is LGPL and the utility (ndctl) that is
GPL.  I'm not sure what the best way is to reflect that distinction in the spec
file.

> > ndctl.x86_64: W: no-manual-page-for-binary ndctl
> 
> ... would be nice.

Yeah, I should bite the bullet and get that done.

> Otherwise looks fine, from a brief look. You are now sponsored, and I'll do
> a more thorough review when you update.

Thanks again Dave!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]