https://bugzilla.redhat.com/show_bug.cgi?id=1243550 Pradeep Kilambi <pkilambi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(pkilambi@redhat.c | |om) | --- Comment #4 from Pradeep Kilambi <pkilambi@xxxxxxxxxx> --- (In reply to Haïkel Guémar from comment #3) Thanks for the review. Replying inline: > ## Blockers > > > * I'll need your help to properly understand ceilometer/aodh relationship > and figure out the proper upgrade path. > > I pretty much get that openstack-aodh-{notifier,evaluator} services replace > services with the same in ceilometer. > Problem is that openstack-ceilometer-{notifier,evaluator} were shipped in a > single openstack-ceilometer-alarm package, previously. That is correct. We discussed weather to keep these together or separate. The reason i split is because these services can be run on thier own nodes. Which would be hard to do if its a single package? If the recommendation is to keep these together as part of deprecation then i understand and can change it. > > => You already obsoletes openstack-ceilometer-alarm but it's unversioned, > should be: > Provides: openstack-ceilometer-alarm = 2:%{version}-%{release} > Obsoletes: openstack-ceilometer-alarm < last n-v-r with epoch of > openstack-ceilometer-alarm > > As ceilometer switched to semantic versioning, we need to carry epoch from > ceilometer in our provides/obsoletes. No need to add epoch to the package > though Yep understand, reason i dint add it yet is i was not sure which version to put in. Since liberty is not out yet? Ideally this version should be the final version of ceilometer-alarm package? Is it ok to add the current version and update later? > > => Problem is that your main package and doesn't require > openstack-aodh-{notifier,evaluator} and hence the upgrade path is still > incorrect. > So either we create a subpackage openstack-aodh-alarm-compat requiring all > the packages providing features from openstack-ceilometer-alarm, so we just I was thinking i can make the aodh-common obsolete ceilometer-alarm. Wouldnt that work? since aodh-common will be required by all sub-packages? > > > Relevant guidelines > [1] > https://fedoraproject.org/wiki/ > Upgrade_paths_%E2%80%94_renaming_or_splitting_packages#.28n:m. > 29_Many_to_many_replacement > > If you're aware of other similar features mapping in ceilometer/aodh, let me > know so we could figure out the upgrade path. > > * use versioned python macros > > * I exempt this package from newer python guidelines as we need to make sure > that the upgrade path from ceilometer alarm is ok before renaming stuff. > Moreover, openstack-xxx packages will be retired from F24 at a later point. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review