Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-pgsql - Enhanced python interface to PostgreSQL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225346 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From kevin@xxxxxxxxx 2007-06-05 22:52 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (PSF) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 8c56355c93c88efacaba94119283175e python-pgsql-0.9.5.tar.gz 8c56355c93c88efacaba94119283175e python-pgsql-0.9.5.tar.gz.1 OK - BuildRequires correct See below - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. Our friend rpmlint says: E: python-pgsql non-executable-script /usr/lib/python2.5/site-packages/pgsql.py 0644 Should this be mode 755? or more likely not have the '#!/usr/bin/env python' at the top? W: python-pgsql invalid-license PSF W: python-pgsql invalid-license PSF W: python-pgsql-debuginfo invalid-license PSF rpmlint wants you to call this: "Python Software Foundation License" Both of those are pretty minor. Provided you fix them before importing I will go ahead and APPROVE this package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review