https://bugzilla.redhat.com/show_bug.cgi?id=1242886 Haïkel Guémar <karlthered@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karlthered@xxxxxxxxx --- Comment #5 from Haïkel Guémar <karlthered@xxxxxxxxx> --- ## blockers This needs to be fixed and carefully tested! * John is right, it needs provides for older package name Provides: openstack-ironic-discover = %{version}-%{release} # needs to be adapted for delorean though. Obsoletes: openstack-ironic-discoverd < 1.1.0-3 * I haven't had the time to check but there was a python-ironic-discoverd subpackage. a) if it has been splitted, the new package needs to provides/obsoletes it b) if it's been merged back in main package, main packages needs to provides/obsoletes it. >From Koji last builds http://koji.fedoraproject.org/koji/buildinfo?buildID=655063 http://koji.fedoraproject.org/koji/rpminfo?rpmID=6438695 http://koji.fedoraproject.org/koji/rpminfo?rpmID=6438696 To check provides/obsoletes in a rpm package rpm -qp --provides <rpm> rpm -qp --provides <rpm> Some very simple sanity checks: * install older package then rpm -Uvh new package and see if it fails. * install new packages and then use yum/dnf to install packages requiring them, see if it fails. ## Minor changes * changelog was not updated * %description should be before %prep * to reduce diff with delorean packages => %{python2_sitelib}/ironic_inspector-*.egg-info https://www.rdoproject.org/packaging/rdo-packaging.html#_differences_between_master_and_rawhide_packaging -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review