https://bugzilla.redhat.com/show_bug.cgi?id=1259532 --- Comment #6 from Pete Walter <walter.pete@xxxxxxxxxx> --- (In reply to Miroslav Suchý from comment #5) > - update-desktop-database is invoked in %post and %postun if package > contains desktop file(s) with a MimeType: entry. > Note: desktop file(s) with MimeType entry in feedreader > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- > database Fixed, good catch. > > FeedReader-1.2.1/src/Widgets/ModeButton.vala > This file seems to have LGPLv3 license (instead of GPLv3). Either clarify it > with upstream or put in SPEC > License: GPLv3+ and LGPLv3+ > and in comment state what file use that LGPLv3+. Added a comment in the spec file. It doesn't matter if one file is licensed with a more relaxed license. The combined work is still GPLv3+. https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F > Package requires other packages for directories it uses. > Note: No known owner of /usr/share/locale/rue, > /usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/ckb/LC_MESSAGES, > /usr/share/locale/ckb I think the filesystem package should own these. Not sure why it doesn't. > Package must own all directories that it creates. > Note: Directories without known owners: > /usr/share/locale/rue/LC_MESSAGES, /usr/share/dbus-1, > /usr/share/locale/ckb/LC_MESSAGES, /usr/share/locale/ckb, > /usr/share/locale/rue, /usr/share/dbus-1/services Added 'Requires: dbus' for /usr/share/dbus-1/services. > > BuildRequires: pkgconfig(sqlite3) > While this is technically speaking correct, it is very unusual at the same > time. > It can confuse other packagers. I would use real name of the package who > provide it. I.e. > BuildRequires: sqlite-devel > And the same for all pkgconfig(*) BR. Most other packages I have checked use pkgconfig() style though. https://fedoraproject.org/wiki/Packaging:PkgConfigBuildRequires says that we should prefer the pkgconfig() style as well. I can definitely change those things if they are needed for approval, just let me know. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review