https://bugzilla.redhat.com/show_bug.cgi?id=1259852 --- Comment #7 from Roman Mohr <roman@xxxxxxxxxxxx> --- (In reply to gil cattaneo from comment #5) > NON blocking issues: > > [?]: Requires correct, justified where necessary. Removed some implicit dependencies from BuildRequires. Assertj can be used with junit or testng. I decided to add assertj as a Requires. A developer can still just install the testng package and use it with assertj. Are there better solutions for this scenario? > > [!]: Latest version is packaged. > Please, consider to upgrading to 2.2.0 or better 2.3.0 I presume you meen 3.1.0 instead of 2.3.0. I updated to 2.2.0. Want to go with that, as 2.2.0 and 3.1.0 are equally well maintained and only 2.2.0 is java7 compatible. Maybe I should also add a "assertj-core3" package? > Suggestion: > Please, remove maven-compiler-plugin > > Please, remove > %pom_xpath_inject "pom:project" " > <properties> > <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> > <maven.compiler.source>1.7</maven.compiler.source> > <maven.compiler.target>1.7</maven.compiler.target> xmvn resisted to accept any other way to tell it that it should use java7 mode. > </properties>" > > you can use > %mvn_build -- -Dproject.build.sourceEncoding=UTF-8 Moved the sourceEncoding to the %mvn_build line -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review