https://bugzilla.redhat.com/show_bug.cgi?id=1222226 --- Comment #2 from Kevin Fenzi <kevin@xxxxxxxxx> --- Thanks much for the review! (In reply to Antonio Trande from comment #1) > - License file COPYING is marked as %doc instead of %license Indeed. fixed. > > - Why you use 'rm -rf $RPM_BUILD_ROOT' ? I used rpmdev-newspec to make the initial spec and it adds one. It's harmless, but I can remove it if you like. > - AutoTools: Obsoleted m4s found > ------------------------------ > AC_PROG_LIBTOOL found in: libXpresent-1.0.0/configure.ac:47 > > See: https://fedorahosted.org/FedoraReview/wiki/AutoTools > > I'm not sure if it's fixed by autoconf. It seems to be cosmetic/not causing any issues currently, but I can let upstream know. > > - libXpresent.i686: W: private-shared-object-provides > /usr/lib/libXpresent.so.1.0.0 libXpresent.so.1 > > This seems to me another false positive related to a supposed bug of > 'fedora-review' > (https://bugzilla.redhat.com/show_bug.cgi?id=1253917). > > The warning does not appear if i use rpmlint directly on > uninstalled/installed RPMs. Yep Updated package: Spec URL: http://www.scrye.com/~kevin/fedora/review/libXpresent/libXpresent.spec SRPM URL: http://www.scrye.com/~kevin/fedora/review/libXpresent/libXpresent-1.0.0-2.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review