[Bug 1260375] Review Request: protozero - Minimalistic protocol buffer decoder and encoder in C++

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1260375



--- Comment #1 from Christopher Meng <i@xxxxxxxx> ---
1. SERIOUS: ExcludeArch. It doesn't support big endian! Don't forget MIPS,
since MIPS is going to be added as a secondary arch.

https://github.com/mapbox/protozero/blob/master/include/protozero/byteswap.hpp

2. make test in %check? Be aware of CXXFLAGS and LDFLAGS.

3. Put %description of main under -devel's %description again please? Since
only -devel is produced after rpmbuild, the description is "This package
contains libraries and header files for
developing applications that use %{name}." however doesn't sound
useful/helpful!

4. %define debug_package %{nil}

Use %global.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]