https://bugzilla.redhat.com/show_bug.cgi?id=1260313 Jens Lody <fedora@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxx --- Comment #4 from Jens Lody <fedora@xxxxxxxxxxx> --- Created attachment 1070858 --> https://bugzilla.redhat.com/attachment.cgi?id=1070858&action=edit Patch that fixes many spec-file issues You should run fedora-review on your package(s) before asking for review: <snip> Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - Header files in -devel subpackage, if present. Note: ganv-lib : /usr/include/ganv-1/ganv/box.h ganv-lib : /usr/include/ganv-1/ganv/canvas.h ganv-lib : /usr/include/ganv-1/ganv/circle.h ganv-lib : /usr/include/ganv-1/ganv/edge.h ganv-lib : /usr/include/ganv-1/ganv/ganv.h ganv-lib : /usr/include/ganv-1/ganv/group.h ganv-lib : /usr/include/ganv-1/ganv/item.h ganv-lib : /usr/include/ganv-1/ganv/module.h ganv-lib : /usr/include/ganv-1/ganv/node.h ganv-lib : /usr/include/ganv-1/ganv/port.h ganv-lib : /usr/include/ganv-1/ganv/text.h ganv-lib : /usr/include/ganv-1/ganv/types.h ganv-lib : /usr/include/ganv-1/ganv/widget.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text </snip> <snip> Rpmlint ------- Checking: ganv-1.4.2-1.fc24.x86_64.rpm ganv-lib-1.4.2-1.fc24.x86_64.rpm ganv-1.4.2-1.fc24.src.rpm ganv.x86_64: E: explicit-lib-dependency ganv-lib ganv.x86_64: E: standard-dir-owned-by-package /usr/bin ganv.x86_64: W: no-manual-page-for-binary ganv_bench ganv-lib.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment ganv-lib.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment ganv-lib.x86_64: W: no-documentation ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/module.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/ganv.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libganv-1.so ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/node.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/port.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/types.hpp ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/text.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/wrap.hpp ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/widget.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/group.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/Box.hpp ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/item.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/types.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/Port.hpp ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/Canvas.hpp ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/Node.hpp ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/box.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/Edge.hpp ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/ganv.hpp ganv-lib.x86_64: E: standard-dir-owned-by-package /usr/lib64 ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/edge.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/Circle.hpp ganv-lib.x86_64: E: standard-dir-owned-by-package /usr/include ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/circle.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/Item.hpp ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/ganv-1.pc ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/canvas.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/Module.hpp 3 packages and 0 specfiles checked; 4 errors, 30 warnings. </snip> I attach a patch that fixes most of these issues (at least the packaging issues). There are still rpmlint error/warnings: <snip> Rpmlint ------- Checking: ganv-1.4.2-1.fc24.x86_64.rpm ganv-lib-1.4.2-1.fc24.x86_64.rpm ganv-devel-1.4.2-1.fc24.x86_64.rpm ganv-1.4.2-1.fc24.src.rpm ganv.x86_64: W: no-manual-page-for-binary ganv_bench ganv-lib.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment ganv-lib.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment ganv-lib.x86_64: W: no-documentation ganv-devel.x86_64: W: only-non-binary-in-usr-lib ganv-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (debuginfo) ------------------- Checking: ganv-debuginfo-1.4.2-1.fc24.x86_64.rpm ganv-debuginfo.x86_64: E: debuginfo-without-sources 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- ganv-debuginfo.x86_64: E: debuginfo-without-sources ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libgtkmm-2.4.so.1 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libatkmm-1.6.so.1 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libgdkmm-2.4.so.1 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libgiomm-2.4.so.1 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libpangomm-1.4.so.1 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libglibmm-2.4.so.1 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libcairomm-1.0.so.1 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libatk-1.0.so.0 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libgdk_pixbuf-2.0.so.0 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libgio-2.0.so.0 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libpangoft2-1.0.so.0 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libfontconfig.so.1 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libfreetype.so.6 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libcdt.so.5 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libpthread.so.0 ganv-lib.x86_64: W: no-documentation ganv.x86_64: W: invalid-url URL: http://drobilla.net/software/ganv '' ganv.x86_64: W: no-manual-page-for-binary ganv_bench ganv-devel.x86_64: W: only-non-binary-in-usr-lib ganv-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 1 errors, 20 warnings. </snip> I have no time to look into these deeper at the moment (at work currently). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review