https://bugzilla.redhat.com/show_bug.cgi?id=1226557 --- Comment #12 from Antonio Trande <anto.trande@xxxxxxxxx> --- - Please, use fully versioned dependency in subpackages. %{name}-data = %{version}-%{release} - Explain what data subpackage contains in Description. - Note this warning: "summary-ended-with-dot C Data files for amsynth." Remove the dot. - License and documentation files missing in data subpackages. Note that ths 'skins' directory provides another README file. In this case, license and documentation files can be packaged only in the data subpackage. - Remember the upstream to update the FSF address. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "ISC", "*No copyright* GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)", "Unknown or generated". 8 files have unknown license. Detailed output of licensecheck in /home/sagitter/1226557-amsynth/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/dssi [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 4 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in amsynth- data , lv2-amsynth-plugins , dssi-amsynth-plugins [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: amsynth-1.5.1-4.fc24.i686.rpm amsynth-data-1.5.1-4.fc24.noarch.rpm lv2-amsynth-plugins-1.5.1-4.fc24.i686.rpm dssi-amsynth-plugins-1.5.1-4.fc24.i686.rpm amsynth-1.5.1-4.fc24.src.rpm amsynth.i686: E: explicit-lib-dependency libsndfile-utils amsynth.i686: W: spelling-error %description -l en_US subtractive -> subtraction, subtract, attractive amsynth.i686: W: spelling-error %description -l en_US waveforms -> waveform, wave forms, wave-forms amsynth.i686: E: incorrect-fsf-address /usr/share/licenses/amsynth/COPYING amsynth.i686: W: no-manual-page-for-binary amsynth amsynth-data.noarch: W: summary-ended-with-dot C Data files for amsynth. amsynth-data.noarch: W: no-documentation lv2-amsynth-plugins.i686: E: incorrect-fsf-address /usr/share/licenses/lv2-amsynth-plugins/COPYING dssi-amsynth-plugins.i686: E: incorrect-fsf-address /usr/share/licenses/dssi-amsynth-plugins/COPYING amsynth.src: W: spelling-error %description -l en_US subtractive -> subtraction, subtract, attractive amsynth.src: W: spelling-error %description -l en_US waveforms -> waveform, wave forms, wave-forms amsynth.src: W: invalid-url Source0: https://github.com/nixxcode/amsynth/releases/download/release-1.5.1/amsynth-1.5.1.tar.gz HTTP Error 403: Forbidden 5 packages and 0 specfiles checked; 4 errors, 8 warnings. Rpmlint (debuginfo) ------------------- Checking: amsynth-debuginfo-1.5.1-4.fc24.i686.rpm amsynth-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/amsynth-1.5.1/src/GUI/controllers.h 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory amsynth.i686: E: explicit-lib-dependency libsndfile-utils amsynth.i686: E: incorrect-fsf-address /usr/share/licenses/amsynth/COPYING amsynth.i686: W: no-manual-page-for-binary amsynth dssi-amsynth-plugins.i686: E: incorrect-fsf-address /usr/share/licenses/dssi-amsynth-plugins/COPYING amsynth-data.noarch: W: summary-ended-with-dot C Data files for amsynth. amsynth-data.noarch: W: no-documentation lv2-amsynth-plugins.i686: E: incorrect-fsf-address /usr/share/licenses/lv2-amsynth-plugins/COPYING amsynth-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/amsynth-1.5.1/src/GUI/controllers.h 5 packages and 0 specfiles checked; 5 errors, 3 warnings. Requires -------- amsynth (rpmlib, GLIBC filtered): amsynth-data jack-audio-connection-kit lash libasound.so.2 libasound.so.2(ALSA_0.9) libatk-1.0.so.0 libatkmm-1.6.so.1 libc.so.6 libcairo.so.2 libcairomm-1.0.so.1 libfontconfig.so.1 libfreetype.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GCC_4.0.0) libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgdkmm-2.4.so.1 libgio-2.0.so.0 libgiomm-2.4.so.1 libglib-2.0.so.0 libglibmm-2.4.so.1 libgobject-2.0.so.0 libgtk-x11-2.0.so.0 libgtkmm-2.4.so.1 libjack.so.0 liblash.so.1 libm.so.6 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 libpangomm-1.4.so.1 libpthread.so.0 libsigc-2.0.so.0 libsndfile-utils libsndfile.so.1 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libuuid.so.1 rtld(GNU_HASH) dssi-amsynth-plugins (rpmlib, GLIBC filtered): amsynth-data dssi libatk-1.0.so.0 libc.so.6 libcairo.so.2 libfontconfig.so.1 libfreetype.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GCC_4.0.0) libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0 libgobject-2.0.so.0 libgtk-x11-2.0.so.0 liblo.so.7 libm.so.6 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 libpthread.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) rtld(GNU_HASH) amsynth-data (rpmlib, GLIBC filtered): lv2-amsynth-plugins (rpmlib, GLIBC filtered): amsynth-data libatk-1.0.so.0 libc.so.6 libcairo.so.2 libfontconfig.so.1 libfreetype.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GCC_4.0.0) libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0 libgobject-2.0.so.0 libgtk-x11-2.0.so.0 libm.so.6 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 libpthread.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) lv2 rtld(GNU_HASH) Provides -------- amsynth: amsynth amsynth(x86-32) appdata() appdata(amsynth.appdata.xml) application() application(amsynth.desktop) dssi-amsynth-plugins: dssi-amsynth-plugins dssi-amsynth-plugins(x86-32) amsynth-data: amsynth-data lv2-amsynth-plugins: lv2-amsynth-plugins lv2-amsynth-plugins(x86-32) Unversioned so-files -------------------- lv2-amsynth-plugins: /usr/lib/lv2/amsynth.lv2/amsynth_lv2.so lv2-amsynth-plugins: /usr/lib/lv2/amsynth.lv2/amsynth_lv2_gtk.so dssi-amsynth-plugins: /usr/lib/dssi/amsynth_dssi.so Source checksums ---------------- https://github.com/nixxcode/amsynth/releases/download/release-1.5.1/amsynth-1.5.1.tar.gz : CHECKSUM(SHA256) this package : 16edc67fe3211b1fa8642657210f7804307fe0e4911cf4137fd523353c726416 CHECKSUM(SHA256) upstream package : 16edc67fe3211b1fa8642657210f7804307fe0e4911cf4137fd523353c726416 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m fedora-rawhide-i386 -b 1226557 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review