https://bugzilla.redhat.com/show_bug.cgi?id=1259416 --- Comment #1 from David King <amigadave@xxxxxxxxxxxxx> --- fedora-review won't build the spec in mock for me (you might be missing a gstreamer1-plugins-base-devel BuildRequires). Anyway, some comments: * it's best to use the pkgconfig(foo) for for BuildRequires if suitable: https://fedoraproject.org/wiki/Packaging:PkgConfigBuildRequires * for users and groups (I guess that the groups do not exist by default): https://fedoraproject.org/wiki/Packaging:UsersAndGroups * licensing documents must use %license, not %doc: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review