https://bugzilla.redhat.com/show_bug.cgi?id=829097 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rc040203@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |rc040203@xxxxxxxxxx Flags| |fedora-review? --- Comment #3 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- Rich, are you still interested in this package? I yes, I am going to proceed with a formal review, otherwise I'd close this request. For the moment, some remarks: - The package supports disabling building static libs. I'd suggest to - %configure --disable-static - rm -rf %{buildroot}%{_libdir}/*.a - I'd suggest to use a program-prefix to avoid the naming issues with ld/lms_config (e.g. %configure --program-prefix=sick-) However, this will only work if other packages don't have ld/lms_config hard-coded somewhere. Proposing upstream to change these tools' names would be appropriate, but I understand upstream is dead. Though I consider these names to be unfortunate, I don't see any actual conflicts between these and other packages. Besides these, this package seems pretty clean to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review