https://bugzilla.redhat.com/show_bug.cgi?id=1258874 --- Comment #8 from Jan Včelák <jv+fedora@xxxxxxxxx> --- OK. Thank you guys. Another update. Spec: https://jvcelak.fedorapeople.org/review/libmaxminddb/1.1.1-3/libmaxminddb.spec SRPM: https://jvcelak.fedorapeople.org/review/libmaxminddb/1.1.1-3/libmaxminddb-1.1.1-3.fc22.src.rpm COPR builds: https://copr.fedoraproject.org/coprs/jvcelak/libmaxminddb/build/112954/ I've rechecked the licensing. The Licence should refer to content in the binary RPM. The original code is Apache Licence 2.0. Some of the code is taken from FreeBSD and resides in maxminddb-compat-util.h, the licence is BSD (2 and 3 clause). The ltmain.sh file is part of the auto tools build system, so we don't have to care. I've updated the Licence tag to: "APL 2.0 and BSD" and added a comment describing this decision. I've updated the change log as I forgot to do that in the previous version. I've patched the libtool to link with --as-needed, so the warning about unused dependency should be gone. I've moved the Changes.md documentation file from the devel subpackage to the main package, so the warning about missing documentation in the main package no longer appears. The "libmaxminddb-devel.x86_64: W: only-non-binary-in-usr-lib" is indeed false positive. It's an *.so symlink to the binary file in the same directory. And it has to be there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review