Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-06-05 12:35 EST ------- (In reply to comment #22) > Latest rpmlint: > > [a@laptop mrxvt_devel]$ rpmlint /usr/src/redhat/RPMS/i386/mrxvt-0.5.2-1.4.i386.rpm > W: mrxvt wrong-file-end-of-line-encoding > /usr/share/doc/mrxvt-0.5.2/scripts/mrxvt.vbs Fix this by: -------------------------------------------------- sed -i 's|\r||' scripts/mrxvt.vbs -------------------------------------------------- in %prep stage. > With regard to the integer + %{?dist} comment, > I assume the current way I'm using it is > correct? Still not. What I wanted to say is that please write release number as ------------------------------------------ Release: 2%{?dist} ------------------------------------------ or ------------------------------------------ Release: 3%{?dist} ------------------------------------------ and not ------------------------------------------ Release: 1%{?dist}.4 ------------------------------------------ > I do need to do three things: > > 1) Verify the buildrequires again... mockbuild succeeds, however there seems to be some missing BR. ( I attach the difference ) > 2) Verify I can use this spec for build from the svn repository. I don't know what you want to say here, but please don't use svn version source if possible. > 3) Apply a new patch from the maintainer that fixes a bug. Also I don't know what you want to say here... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review