[Bug 238237] Review Request: perl-Catalyst-Plugin-Static-Simple - Make serving static pages painless

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Plugin-Static-Simple - Make serving static pages painless


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238237


panemade@xxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade@xxxxxxxxx  2007-06-05 12:24 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
930594a0490af190eed4f62ac1ac5e9b  Catalyst-Plugin-Static-Simple-0.15.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
+ ./Build test
t/01use.............ok
t/02pod.............ok
t/03podcoverage.....ok
t/04static..........ok
t/05dirs............ok
t/06include_path....ok
t/07mime_types......ok
t/08subreq..........ok
t/09ignore_ext......ok
t/10ignore_dirs.....ok
All tests successful.
Files=10, Tests=41,  6 wallclock secs ( 3.55 cusr +  0.30 csys =  3.85 CPU)
+ exit 0
+ Provides: perl(Catalyst::Plugin::Static::Simple) = 0.15
+ Requires: perl(:MODULE_COMPAT_5.8.8) perl(Catalyst) >= 5.30 perl(File::Spec)
perl(File::stat) perl(IO::File) perl(MIME::Types) perl(base) perl(strict)
perl(warnings)


APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]