[Bug 1254828] Review Request: python-networking-bigswitch - big switch neutron plugin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1254828

Haïkel Guémar <karlthered@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(karlthered@gmail. |
                   |com)                        |



--- Comment #28 from Haïkel Guémar <karlthered@xxxxxxxxx> ---
We're almost done, please apply the following changes:
* fix the following rpmlint errors/warnings
python-networking-bigswitch.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/bsnstacklib/plugins/bigswitch/tests/test_server.py
644 /usr/bin/env
python-networking-bigswitch.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/bsnstacklib/plugins/bigswitch/version.py 644
/usr/bin/env  
python-networking-bigswitch.src:21: W: mixed-use-of-spaces-and-tabs (spaces:
line 6, tab: line 21)

Use sed to drop the shebang, here's a snippet that could help you.
https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries


As your also an upstream maintainer, please consider updating requirements.txt
as downstream use it to check runtime requirements (rdopkg reqcheck serves that
particular goal).

When you're done, needinfo me and I'll add it in delorean.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]