https://bugzilla.redhat.com/show_bug.cgi?id=1255505 --- Comment #6 from Will Woods <wwoods@xxxxxxxxxx> --- (In reply to Adam Williamson from comment #5) > Package Review > ============== > > Notes: > > * The license file is not included in the module packages, but they can be > installed without the main package. Fixed. > * Creates a file in /usr/lib/systemd/system/system-update.target.wants , but > doesn't own it or depend on PackageKit (which owns it). This is tricky. PackageKit shouldn't own that directory. It *would* be created if we were using 'systemctl enable', but the spec specifically says: To make things a bit more robust we recommend hooking the update script into system-update.target via a .wants/ symlink in the distribution package, rather than depending on "systemctl enable" in the postinst scriptlets of your package. More specifically, for your update script create a .service file, without [Install] section, and then add a symlink like [...]system-update.target.wants/foobar.service → ../foobar.service to your package. Probably we should make systemd own that directory? Or can both PackageKit and dnf-plugin-system-upgrade own it? > * Changelog is missing releases (it has '0.3.0', should have '0.3.0-1') Fixed. > * Might be nice for [Unit] in the service file to include a Documentation= > line, per the guidelines: https://fedoraproject.org/wiki/Packaging:Systemd Added; will be expanded when there's a man page. > * The guidelines also say "Unit files should avoid using StandardOutput= or > StandardError=", but I'm gonna guess this is a special case? Yes, because we really do need the output/stderr to go to the screen. > * "Requires: python-%{name}" is not versioned - perhaps it ought to be? No, because we want to pull the default version for whichever is the default Python stack; this is handled by the %python_provide nonsense. See the dnf spec for another example of this behavior. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review