[Bug 1256435] Review Request: metapixel - photomosaic generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1256435



--- Comment #15 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
- Impossible to review this package, because *.spec does not match the srpm.
=>  metapixel-copyright.patch and metapixel-install.patch are missing.

- If metapixel-copyright.patch is what I presume it is (Changing the FSF
address) then it's superfluous, because it's legally irrelevant.

- MUSTFIX: Add %{?dist} to release

- make PREFIX=... is pretty much useless.
You need to add BINDIR and MANDIR as well.

- Requires: perl also seems superfluous. Rpm automatically adds appropriate R:
to packages containing perl scripts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]