[Bug 1256435] Review Request: metapixel - photomosaic generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1256435

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx



--- Comment #10 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
(In reply to Neil Horman from comment #9)
> All fixed, new version available, thanks!

Well,
- this package doesn't honor CFLAGS:
...
gcc -I/sw/include -I/usr/X11R6/include -I/usr/X11R6/include/X11 -I. -Irwimg
-Wall -O2   -DMETAPIXEL_VERSION=\"1.0.2\" -DRWIMG_JPEG -DRWIMG_PNG -DRWIMG_GIF
-c metapixel.c
...

- this package doesn't honor ans installation paths. 
This is the origin why "make install" appears broken to you and likely is why
you resorted to manual installation.

- this package's "release" lacks %{?dist}

- there still are superflous deps:
# rpmlint metapixel-1.0.2-1.x86_64.rpm 
metapixel.x86_64: E: explicit-lib-dependency giflib
metapixel.x86_64: E: explicit-lib-dependency libjpeg
metapixel.x86_64: E: explicit-lib-dependency libpng

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]