https://bugzilla.redhat.com/show_bug.cgi?id=1230161 --- Comment #6 from Petr Šabata <psabata@xxxxxxxxxx> --- (In reply to William Moreno from comment #5) > 1- You SHOULD add a appdata.xml file to show this app in Gnome Software > https://fedoraproject.org/wiki/Packaging:AppData I don't think this browser aims at standard desktop users but I'll consider it. > 3- This BR are not needed: coreutils make sed They are. Multiple utilities from coreutils are called in the Makefile, so is sed. Additionally, sed is called in the spec file, too. > 4- This app do not have a icon, so I will recomend add this line > to the desktop file: > > Icon=web-browser This doesn't appear to be a universal name (few icon sets seem to have it) but I'm no expert on the matter. I'll add it. > 5- [ ]: %build honors applicable compiler flags or justifies otherwise. > In build I will recomend to use make %{?_smp_mflags} CFLAGS are set on line 45. I'll add the flags for make. Missed that, thanks. b> Please fix these issues to check: > [ ]: Package complies to the Packaging Guidelines I hope it does :) > Provides > -------- > jumanji: > application() > application(jumanji.desktop) > jumanji > jumanji(x86-64) Do you have an idea what the empty `application()' virtual provide means? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review