Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: audio-entropyd - Generate entropy from audio output https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241804 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From kevin@xxxxxxxxx 2007-06-04 23:52 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 0957c4817aba487966fc711d77182576 audio-entropyd-1.0.0.tgz 0957c4817aba487966fc711d77182576 audio-entropyd-1.0.0.tgz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version Issues: 1. rpmlint has one lone line of output: W: audio-entropyd service-default-enabled /etc/rc.d/init.d/audio-entropyd As you say there shouldn't be a problem enabling this by default. 2. Should there be a condrestart for upgrades? You can add one if you think it makes sense. I see no blockers, so this package is APPROVED. Don't forget to close this review once you have imported and built this package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review