Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-idle - IRC connection manager for Telepathy https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240324 ------- Additional Comments From kevin@xxxxxxxxx 2007-06-04 23:20 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (LGPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 4e782df6d3858b4886d3a23be475c17e telepathy-idle-0.0.5.tar.gz 4e782df6d3858b4886d3a23be475c17e telepathy-idle-0.0.5.tar.gz.1 See below - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag See below - Should package latest version Issues: 1. Non blocker/Cosmetic: rpmlint says: W: telepathy-idle mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 13) Fix if you like. 2. possible missing buildrequires? From the build.log: ./configure: line 20691: GTK_DOC_CHECK: command not found BuildRequires: gtk-doc? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review