https://bugzilla.redhat.com/show_bug.cgi?id=1223673 Milan Bouchet-Valat <nalimilan@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nalimilan@xxxxxxx Assignee|nonamedotc@xxxxxxxxx |nalimilan@xxxxxxx --- Comment #7 from Milan Bouchet-Valat <nalimilan@xxxxxxx> --- OK, looks pretty good except for a few minor points, and the unversioned .so files in the path, which is common with llvm and llvm34. I'm inclined to say that's OK for now, and we should try to fix this in the llvm package first.. It's not like we're introducing a new bug... Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Minor point: I realized each subpackage creates its own directory under /usr/share/doc/. Since they contain very few files and most apply to all subpackages (e.g. LICENSE.txt), wouldn't it be better to put everthing under a common llvm dir? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "ISC", "Unknown or generated". 2580 files have unknown license. Detailed output of licensecheck in /home/milan/Dev/Fedora/llvm35-review/llvm35/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/llvm35 [!]: %build honors applicable compiler flags or justifies otherwise. Could you add a comment explaining why %{optflags} is ignored and why --with-optimize-option=-O3 is a good idea? [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 890880 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: llvm35-static. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [-]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in llvm35-doc , llvm35-libs , llvm35-static [x]: Package functions as described. [-]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. Could use a bit more verbose comments and links to upstream patches. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1024000 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: llvm35-3.5.2-1.fc22.x86_64.rpm llvm35-devel-3.5.2-1.fc22.x86_64.rpm llvm35-doc-3.5.2-1.fc22.noarch.rpm llvm35-libs-3.5.2-1.fc22.x86_64.rpm llvm35-static-3.5.2-1.fc22.x86_64.rpm llvm35-3.5.2-1.fc22.src.rpm llvm35.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment Could fix this one. llvm35.x86_64: W: no-manual-page-for-binary llvm-diff-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-stress-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-ar-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-nm-3.5 llvm35.x86_64: W: no-manual-page-for-binary llc-3.5 llvm35.x86_64: W: no-manual-page-for-binary lli-child-target-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-bcanalyzer-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-tblgen-3.5 llvm35.x86_64: W: no-manual-page-for-binary opt-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-profdata-3.5 llvm35.x86_64: W: no-manual-page-for-binary bugpoint-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-symbolizer-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-rtdyld-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-cov-3.5 llvm35.x86_64: W: no-manual-page-for-binary lli-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-objdump-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-mcmarkup-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-mc-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-as-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-readobj-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-link-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-dwarfdump-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-extract-3.5 llvm35.x86_64: W: no-manual-page-for-binary macho-dump-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-size-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-dis-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-ranlib-3.5 llvm35-devel.x86_64: W: no-manual-page-for-binary llvm-config-64-3.5 Why don't we have manpages for all those commands, even in the standard llvm package? llvm35-libs.x86_64: W: no-documentation llvm35-static.x86_64: W: no-documentation llvm35.src: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment llvm35.src:115: E: hardcoded-library-path in /usr/lib False positive. llvm35.src:177: E: hardcoded-library-path in %{_prefix}/lib/gcc/%{_target_cpu}*/*/include) Out of curiosity, why doesn't gcc install these files under %{_libdir}? 6 packages and 0 specfiles checked; 2 errors, 32 warnings. Rpmlint (debuginfo) ------------------- Checking: llvm35-debuginfo-3.5.2-1.fc22.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- llvm35.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment llvm35.x86_64: W: no-manual-page-for-binary llvm-diff-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-stress-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-ar-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-nm-3.5 llvm35.x86_64: W: no-manual-page-for-binary llc-3.5 llvm35.x86_64: W: no-manual-page-for-binary lli-child-target-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-bcanalyzer-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-tblgen-3.5 llvm35.x86_64: W: no-manual-page-for-binary opt-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-profdata-3.5 llvm35.x86_64: W: no-manual-page-for-binary bugpoint-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-symbolizer-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-rtdyld-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-cov-3.5 llvm35.x86_64: W: no-manual-page-for-binary lli-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-objdump-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-mcmarkup-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-mc-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-as-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-readobj-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-link-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-dwarfdump-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-extract-3.5 llvm35.x86_64: W: no-manual-page-for-binary macho-dump-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-size-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-dis-3.5 llvm35.x86_64: W: no-manual-page-for-binary llvm-ranlib-3.5 llvm35-devel.x86_64: W: no-manual-page-for-binary llvm-config-64-3.5 llvm35-static.x86_64: W: no-documentation llvm35-libs.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 31 warnings. Requires -------- llvm35-doc (rpmlib, GLIBC filtered): llvm35 llvm35 (rpmlib, GLIBC filtered): libLLVM-3.5.so()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libffi.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libtinfo.so.5()(64bit) libz.so.1()(64bit) llvm35-libs(x86-64) rtld(GNU_HASH) llvm35-static (rpmlib, GLIBC filtered): llvm35-devel(x86-64) llvm35-devel (rpmlib, GLIBC filtered): /bin/sh /usr/sbin/alternatives libc.so.6()(64bit) libdl.so.2()(64bit) libffi-devel libffi.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++-devel libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtinfo.so.5()(64bit) libz.so.1()(64bit) llvm35(x86-64) ncurses-devel rtld(GNU_HASH) llvm35-libs (rpmlib, GLIBC filtered): /sbin/ldconfig config(llvm35-libs) libLLVM-3.5.so()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libffi.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libtinfo.so.5()(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.0)(64bit) rtld(GNU_HASH) Provides -------- llvm35-doc: llvm35-doc llvm35: llvm35 llvm35(x86-64) llvm35-static: llvm35-static llvm35-static(x86-64) llvm35-devel: llvm35-devel llvm35-devel(x86-64) llvm35-libs: config(llvm35-libs) libLLVM-3.5.so()(64bit) libLTO.so()(64bit) llvm35-libs llvm35-libs(x86-64) Unversioned so-files -------------------- llvm35-libs: /usr/lib64/llvm35/BugpointPasses.so llvm35-libs: /usr/lib64/llvm35/LLVMgold.so llvm35-libs: /usr/lib64/llvm35/libLLVM-3.5.2.so llvm35-libs: /usr/lib64/llvm35/libLLVM-3.5.so llvm35-libs: /usr/lib64/llvm35/libLTO.so Source checksums ---------------- http://llvm.org/releases/3.5.2/llvm-3.5.2.src.tar.xz : CHECKSUM(SHA256) this package : 44196156d5749eb4b4224fe471a29cc3984df92570a4a89fa859f7394fc0c575 CHECKSUM(SHA256) upstream package : 44196156d5749eb4b4224fe471a29cc3984df92570a4a89fa859f7394fc0c575 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -rn llvm35-3.5.2-1.fc21.src.rpm Buildroot used: fedora-22-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review