https://bugzilla.redhat.com/show_bug.cgi?id=1228203 --- Comment #5 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Jerry James from comment #4) > Issues, in no particular order > - There is one bundled source file: > > src/main/java/org/springframework/data/redis/connection/util/Base64.java Removed. Use jvm Base64 > It carries a BSD license. It probably isn't packaged anywhere, since it is > a single class file, so I'm not concerned about the bundling. I don't know > what that does to the license field, though. If ASL 2.0 subsumes BSD, then > the current license tag is fine. Otherwise, it needs to be "ASL 2.0 and > BSD", with a comment explaining the license breakdown. Only for information net.iharder:base64 is under Public Domain license > - The final requires include "mvn(junit:junit)". Is that correct, or is that > an unintended side effect of adding test deps in %prep? Fixed > - Under the Java section is a question about whether the upstream build > method > is used. That doesn't appear to be the case here. The build is being done > with maven, but it looks like gradle is the upstream build tool of choice. > I'm ignorant about such matters, though. Does this matter? No, is irrilevant Spec URL: https://gil.fedorapeople.org/springframework-data-redis.spec SRPM URL: https://gil.fedorapeople.org/springframework-data-redis-1.3.5-2.fc22.src.rpm Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10874153 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review