[Bug 1256100] Review Request: cryptominisat4 - SAT solver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1256100



--- Comment #5 from gil cattaneo <puntogil@xxxxxxxxx> ---
ISSUES:
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "LGPL", "GPL (v3 or later)", "Unknown or generated", "MIT/X11
     (BSD like)", "BSD (2 clause)", "GPL (v2)", "*No copyright* MIT/X11
     (BSD like)". 44 files have unknown license. Detailed output of
     licensecheck in /home/gil/1256100-cryptominisat4/licensecheck.txt

see above, license field should be: 
BSD and GPLv2+ LGPLv2+ and MIT

[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/cmake(cmake,
     qt5-qtlocation, qt5-qtbase)

 Please, use: %{_libdir}/cmake/cryptominisat4

Suggestion:
cryptominisat4.src:87: E: hardcoded-library-path in %{_prefix}/lib/lib%{name}*
cryptominisat4.src:88: E: hardcoded-library-path in %{_prefix}/lib/cmake
cryptominisat4.src:89: E: hardcoded-library-path in
%{_prefix}/lib/|%{_libdir}/|'
can you patch cmake file, chaging the hardcoded ${dir}/lib with
${LIB_INSTALL_DIR}
e.g. %{__cmake} -DCMAKE_INSTALL_PREFIX:PATH=%{_prefix}
-DLIB_INSTALL_DIR:PATH=%{_libdir} -DALSO_BUILD_STATIC_LIB=OFF .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]