[Bug 1254828] Review Request: python-networking-bigswitch - big switch neutron plugin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1254828



--- Comment #23 from Ihar Hrachyshka <ihrachys@xxxxxxxxxx> ---
I believe main python package should depend on python-neutron not
openstack-neutron-common. The latter should be the dependency for your agent.

Summary for -doc sub package is wrong.

In -doc description, documentations => documentation

Is python-networking-bigswitch-agent the name of the package you desire? I
would think that openstack-neutron-bigswitch-agent is a better one. Same for
lldp.

You don't need -n for description of -doc sub package either.

Why do you remove .egg-info in %prep? You should probably reuse it.

add SKIP_PIP_INSTALL in build too.

Otherwise looks good to me. I think we are close to claiming victory. :) Thanks
for respinning the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]