https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #18 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Here we go: naming: ok mostly 1. SHOULD: I'd suggest naming -common as -libs instead, it's a more common practice. And adjust dependencies accordingly 2. SHOULD replace %{_datadir}/icons/hicolor/16x16/apps/* %{_datadir}/icons/hicolor/48x48/apps/* ... with single/simpler glob: %{_datadir}/icons/h%{_sysconfdir}/hicolor/*/apps/* 3. MUST fix dir ownership, you include: %config %{_sysconfdir}/ownCloud/sync-exclude.lst but nothing owns the %{_sysconfdir}/ownCloud , please add %dir %{_sysconfdir}/ownCloud 4. MUST fix obsoletes/provides. you include Obsoletes: for mirall, but no matching provides, please add in the right places: # main pkg: Obsoletes: mirall < 1.8.0 Provides: mirall = %{version}-%{release} # -devel subpkg Obsoletes: mirall-devel < 1.8.0 Provides: mirall-devel = %{version}-%{release} # -common/-libs subpkg, depending on 1 above Obsoletes: mirall-common < 1.8.0 Provides: mirall-common = %{version}-%{release} # -nautilus subpkg, with fixed spelling Obsoletes: mirall-nautilus < 1.8.0 Provides: mirall-nautilus = %{version}-%{release} (and move Obsoletes to match their subpkg locations) sources: ok ce82c234fca674062599b3ceb4ac50c6 owncloudclient-1.8.4.tar.xz 5. MUST validate appdata, add BuildRequires: libappstream-glib and to %check section: appstream-util validate-relax --nonet %{buildroot}%{datadir}/appdata/%{name}.appdata.xml 6. MUST: -devel pkg includes static libs, so add to -devel pkg: Provides: %{name}-static = %{version}-%{release} (or alternatively, omit %{_libdir}/libhttpbf.a %{_includedir}/httpbf.h from packaging altogether if you're sure nothing else needs it) 7. MUST licensing: NOT ok. looks like the stuff under csync/ dir is all LGPLv2+, and only the client code is GPLv2 (no +), so I'd recommend adding (including comments): (main) # -libs are LGPLv2+, rest GPLv2 License: LGPLv2+ and GPLv2 (in -libs/-devel subpkgs) License: LGPLv2+ Please address all MUST items, and I think we're good to go. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review