https://bugzilla.redhat.com/show_bug.cgi?id=1254828 --- Comment #21 from Ihar Hrachyshka <ihrachys@xxxxxxxxxx> --- Please split %description and %package section with newlines. Summary is not ideal. Better: "Big Switch Networks plugin for OpenStack Networking" %{rpm_prefix} is not an ideal name since in some places it's a postfix for you (f.e. in python-%{rpm_prefix}). You don't need to pass -n to %package since all your packages start with python-networking-bigswitch anyway. So "%package -n python-%{rpm_prefix}-*" => "%package *" You should disable pbr version determination mechanisms on build phase: https://github.com/openstack-packages/neutron/blob/rpm-master/openstack-neutron.spec#L443 Please remove Group: tags, they are not needed since long time. I don't think you should directly depend on systemd. You ship systemd units, but that's it. There is nothing that requires it, strictly speaking. Should your dependencies be more specific about versions needed for the package? Your packages should not depend on openstack-neutron which contains other neutron services, but on either openstack-neutron-common (for service subpackages) or on python-neutron (for python subpackage). Include license in every subpackage. Since you have a systemd unit in the package, you should register it. See: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd "Neutron Big Switch Networks LLDP package" -> "Neutron Big Switch Networks LLDP service" .service files look fine, thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review