https://bugzilla.redhat.com/show_bug.cgi?id=1213184 Jan Grulich <jgrulich@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Jan Grulich <jgrulich@xxxxxxxxxx> --- 1) Typo in BuildRequires: qt5-tools-devel, should be qt5-qttools-devel 2) Use %license macro instead of %doc for the license file 3) Some python files are also under BSD license so maybe the license should be LGPLv2+ and BSD Otherwise looks good, all mentioned issues are not blockers and can be simply fixed during import. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review