https://bugzilla.redhat.com/show_bug.cgi?id=1015868 Yajo <yajo.sk8@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(yajo.sk8@xxxxxxxx | |m) | --- Comment #34 from Yajo <yajo.sk8@xxxxxxxxx> --- (In reply to Raphael Groner from comment #29) > ===== MUST items ===== > > C/C++: > [!]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. How to do this? > Generic: > Python: > [!]: Package meets the Packaging Guidelines::Python > => Please consider to build for Python3. Seems not possible: https://github.com/hlamer/qutepart#building-and-installation-on-linux > ===== SHOULD items ===== > > Generic: > [?]: Package functions as described. It does. > [?]: Latest version is packaged. I'll update ASAP to 2.2.2. > [!]: %check is present and all tests pass. > => Maybe consider to execute the provided tests in subfolder. I added these lines: %check %{__python2} tests/run_all.py Now, when building, I get this: Ejecutando(%check): /bin/sh -e /var/tmp/rpm-tmp.WGauMV + umask 022 + cd /home/yajo/rpmbuild/BUILD + cd qutepart-2.2.0 + /usr/bin/python2 tests/run_all.py run_all.py: cannot connect to X server Seems like I need an X server for testing. How to do that? For now, I removed %check. > Rpmlint > ------- > python-qutepart.x86_64: I: enchant-dictionary-not-found es > => Ignore. https://fedorahosted.org/autoqa/ticket/239 I removed the Spanish translation. I guess it will be easier to maintain and understand for others. > python-qutepart.x86_64: W: incoherent-version-in-changelog 2.2.0-6 > ['2.2.0-7.1', '2.2.0-7.1'] See comment #30. > => Please fix. > python-qutepart.x86_64: E: non-standard-executable-perm > /usr/lib64/python2.7/site-packages/qutepart/syntax/cParser.so 775 > => Please fix. Fixed > Diff spec file in url and in SRPM > --------------------------------- > [...] Also see comment #30. SPEC URL: https://doc-14-44-docs.googleusercontent.com/docs/securesc/ha0ro937gcuc7l7deffksulhg5h7mbp1/qc6jbhsdf33ma0e29lrdv0blr4i1e19m/1440568800000/12408635912512098830/*/0B6L4jqW88ytdWDZKanBRa0FEbEk?e=download SRPM URL: https://doc-0s-44-docs.googleusercontent.com/docs/securesc/ha0ro937gcuc7l7deffksulhg5h7mbp1/abmvj2ng3qfbs27qet3p6rphcie4c1s3/1440568800000/12408635912512098830/*/0B6L4jqW88ytdMjhpWm5LMjQ2aGs?e=download -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review