[Bug 1256353] Review Request: python-editor - Programmatically open an editor, capture the result.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1256353



--- Comment #4 from Chandan Kumar <chkumar246@xxxxxxxxx> ---
Hello Social,

Thanks for submitting the package for review.
Below is my inline comments:

[1.] under %prep section, Remove bundled egg-info by adding
rm -rf %{pypi_name}.egg-info

[2.] since there is no test folder, you can remove %check macro

[3.] under %files,
Please replace %{python2_sitelib}/* with

%{python2_sitelib}/editor.py*
%{python2_sitelib}/python_editor-%{version}-py?.?.egg-info

Note: editor.py may contains some byte compiled files which needs to be
required under exceution.

[4.] under %files -n python3-editor section
include
%doc README

replace %{python3_sitelib}/editor.py with %{python3_sitelib}/editor.py*

[5.] Please add the changelog for the spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]