[Bug 725733] Review Request: rubygem-closure-compiler - Ruby Wrapper for the Google Closure Compiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=725733



--- Comment #3 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
Spec URL:
https://fedorapeople.org/cgit/vondruch/public_git/rubygem-closure-compiler.git/tree/rubygem-closure-compiler.spec?id=db1e3875060985324ffc58e90fc4d1c82090f9cd
SRPM URL:
http://people.redhat.com/vondruch/rubygem-closure-compiler-1.1.11-1.fc24.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10820973


So here is the updated version. I am not sure about several things.

* How to best use the CC.
  - Originally, the cc.jar was included in library. I remove it and patch the
    library quite extensively to use %{_bindir}/closure-compiler instead.
    Nevertheless, the far simpler approach would be to replace the .jar file
    by symlink, but that would mean that the filename will not correctly
    reflect the actual version of CC neither the internal constant would be
    correct. Another option would be to stay closer to upstream and use the
    "java -jar" call, but that fails with "Closure::Error: no main manifest
    attribute, in /usr/share/java/closure-compiler/closure-compiler.jar" error
    and I was told that this is not supported way how to execute Java stuff
    on Fedora. So any opinion in this matter?

* Best way to require CC.
  - So far, I used BR: closure-compiler but I might change it to
    BR: %{_bindir}/closure-compiler, since that is the executable used
    in the end.
  - As a alrernative, I could require 
    mvn(com.google.javascript:closure-compiler) instead, but that probably does
    not express clearly what the package needs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]