[Bug 1250526] Review Request: perl-Iterator-Simple-Lookahead - Simple iterator with look-ahead and unget

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1250526

Petr Šabata <psabata@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Petr Šabata <psabata@xxxxxxxxxx> ---
(In reply to Petr Pisar from comment #2)
> (In reply to Petr Šabata from comment #1)
> > * Missing buildtime dependency: sed, used on line 46
> > 
> I fixed it. Updated package is on the same URL.

Ack.

> > * Correct EOLs of lib/Iterator/Simple/Lookahead.pm, too.
> I do not want to convert this file. It's a code, not a documentation. In my
> opinion, EOL normalization applies to documentation only.

It's kind of both.  The file even contains more POD than Perl code :)
Anyhow, subjective and non-critical.  Approving.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]