[Bug 1254828] Review Request: <python-networking-bigswitch> - <big switch neutron plugin>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1254828



--- Comment #10 from Ihar Hrachyshka <ihrachys@xxxxxxxxxx> ---
I believe you should fix your branches and the way you track dependencies in
upstream first. For example:

- you should not depend on neutron master in kilo stable branch;
- you should be explicit about libraries you use directly in your code instead
of relying on neutron to fetch them for you;
- gates for both master and stable/kilo seem to be broken;
- your requirements versions in stable/kilo do not reflect what is in
openstack/requirements:global-requirements.txt in stable/kilo so it can't be
expected it will work with neutron stable/kilo.

If I can suggest to you, I really encourage you to avoid splitting the library
into so tiny pieces. You will only have additional burden to maintain all of
them, while little benefit. If you want to split some pieces into separate RPM
packages, it is a lot easier done with RPM subpackages than with maintaining
three separate packages on pypi. Also, it's still not clear how you end up with
the package that does not contain the agent while it's in your repository. I
suspect you went thru some manual process, and I strongly discourage you from
do it that way. You can release your libraries with git tags in upstream.

And to add, you need to build documentation and put it into a subpackage, not
just stop shipping it as you did lately.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]