Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-gammu - Python bindings for Gammu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239526 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-06-04 21:10 EST ------- Review: + package builds in mock (development i386). - rpmlint is NOT silent for SRPM + rpmlint is silent for RPM. + source files match upstream url a2470a7336286805d9698b3d67bb23c1 python-gammu-0.20.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Provides: Core.so + Requires: gammu libGammu.so.1 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libm.so.6 libpthread.so.0 libpython2.5.so.1.0 python(abi) = 2.5 rtld(GNU_HASH) APPROVED Don't forget to solve rpmlint warning on SRPM. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review