Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: digitemp - Dallas Semiconductor 1-wire device reading console application https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221776 ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxxxx 2007-06-04 17:30 EST ------- REVIEW for d209fbf3702edccc4c4f2afe097bb948 digitemp-3.5.0-1.src.rpm Must: OK - rpmlint is silent on all packages OK - package named according to naming guidelines OK - spec named according to naming guidelines OK - package meets packaging guidelines OK - license open source compatible (GPL v.2) OK - license in spec matches actual license OK - license included in source and in %doc OK - spec in American English OK - spec is legible OK - source in SRPM matches upstream source by md5 OK - source URL in spec valid OK - successfully builds into binary rpms on i386 OK - no known ExcludeArchs OK - BuildRequires correct OK - no locales to take care of OK - not relocatable OK - package owns all directories that it creates OK - no duplicates in %files listing OK - permissions on files are set properly Minor - Please change %defattr to (-,root,root,-) instead of (-,root,root) OK - valid clean section present OK - macros usage consistent OK - code, not content OK - no large docs, no need for a -doc subpackage OK - docs don't affect runtime OK - no need for a -devel subpackage OK - no libtool archives OK - no need for a desktop file OK - doesn't own files or directories that are already owned by other packages OK - $RPM_BUILD_ROOT deleted at beginning of install OK - files are valid UTF-8, manpage is converted properly with iconv SHOULD: OK - Builds in mock OK - program doesn't segfault, but I can't really test if it's working because I don't have the required temperature sensors. Nevertheless this package is APPROVED One last thing: You should think about including SOURCE0/{perl,python,rrdb} dirs, they contain documentation and useful scripts. In this case I think it's best to separate them into a subpackage called "-examples" or "-doc". Make sure, none of the files inside %{_docdir} is executable. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review