https://bugzilla.redhat.com/show_bug.cgi?id=1252924 Shawn Iwinski <shawn.iwinski@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required As usual, remove EPEL 5 bits after initial import [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) Diff is minor and not a blocker (see attached review for diff if interested) No blockers ===== APPROVED ===== -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review