[Bug 1251834] Review Request: python-rackspace-auth-openstack - Rackspace authentication for openstack clients

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1251834



--- Comment #4 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
%{python2_sitelib}/%{modname}
%{python2_sitelib}/%{modname}/*

The first line say "include directory %{python2_sitelib}/%{modname} and
everything below".
The second line say "include %{python2_sitelib}/%{modname}/* and everything
below".
Therefore
  %{python2_sitelib}/%{modname}/*
is listed twice.
It should be:
  %dir %{python2_sitelib}/%{modname}
  %{python2_sitelib}/%{modname}/*
or even simplier:
  %{python2_sitelib}/%{modname}


Cleaning buildroot tag in %install is not needed (unless you target EL5).See 
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

Requires:       python3-novaclient
Requires:       python3-httpretty
Requires:       python3-py
Requires:       python3-invoke
^ This should be put after
%package -n python3-rackspace-auth-openstack
Otherwise it is listed as requires for python-%{project}.
Note: BuildRequires are correct and should stay on the place where it is now.


> SRPM URL: https://immanetize.fedorapeople.org/python-rackspace-auth-openstack-1.3-1.fc24.src.rpm
This is still created using old one spec file. Be careful.
This is exactly the reason why it is good habit to increment release with
*every* change of spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]