[Bug 1246903] Review Request: gnome-shell-extension-openweather - an extension to display weather information from many locations in the world

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1246903



--- Comment #14 from Jens Lody <fedora@xxxxxxxxxxx> ---
https://rpm.jenslody.de/review/gnome-shell-extension-openweather-1-0.1.20150821git97c21a5.fc22.src.rpm
https://rpm.jenslody.de/review/gnome-shell-extension-openweather.spec

Updated spec-file and small updates to the build-system, so the about-tab in
preferences shows either the version automatically given by
extensions.gnome.org (as it was before) or the value of the
%{checkout}-variable from the specfile (gitabcd1234).

The triggers seem to work, installing and removing the package do a recompile
of gschemas.compiled.
I made the requirement on gnome-shell conditional and used
gnome-shell-extension-common for older releases to avoid unowned directories.
Without gnome-shell as requirement I also get a warning about using unowned
directories (glib2.0/schemas), but I decided to ignore these, because glib2 is
in the dependency-chain of gnome-shell-extension-common, so this should not be
a problem.

With fedora-review I get an issue (in fc24-builds), because of the missing (or
better conditional) schema-compiling in %postun and %posttrans, but this can be
ignored with the new file-triggers.

I also shortened the summary, after reading some more about it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]