https://bugzilla.redhat.com/show_bug.cgi?id=1255154 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Spec file differs - The .spec file you attached differs from the .spec file from SRPM. But they differs just in the initial import comment, so this is just minor nit. * License - The license tag should be "ASL 2.0", according to [1]. * Test suite - Please execute the test suite. * Inappropriate language in description - I don't think that words like "bullshit" are appropriate in package description. - I would suggest to ask upstream to change the wording. * Exclude %{_bindir}/rubygems-cabin-test - I don't think this executable is useful. It seems to be just some test stuff. - Could you please ask upstream to remove this executable from the official package, i.e. drop this [2] line? [1] https://fedoraproject.org/wiki/Licensing:Main#Software_License_List [2] https://github.com/jordansissel/ruby-cabin/blob/master/cabin.gemspec#L18 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review